Hi Christophe, On Sat, Jun 11, 2022 at 4:42 PM Christophe Leroy <christophe.leroy@xxxxxxxxxx> wrote: > Same here, the prototype should go in a header file., should be 'void > __init' (and indeed the __init is pointless in the prototype, only > matters in the function definition). I'll change the order, but I don't see a good place for the prototype other than the .c file. It's not a big deal to keep it there. > > Maybe the name should be pnv_rng_init() like the setup arch below. All the rng.c files are powernv_ prefixed, not pnv_ prefixed. Jason
