Hi Christophe, On Sat, Jun 11, 2022 at 4:40 PM Christophe Leroy <christophe.leroy@xxxxxxxxxx> wrote: > > > > +__init void microwatt_rng_init(void); > > This prototype should be declared in a header file, for instance asm/setup.h Alright. > And I think the __init keyword usually goes after the type, so should be > 'void __init'. Indeed I thought so too. It just wasn't like this before, but that doesn't mean I shouldn't fix it. v3 coming right up. Jason