On Fri, Jun 10, 2022 at 04:22:00AM +0000, Oleksandr Tymoshenko wrote:
> I believe this commit introduced a regression in dm verity on systems
> where data device is an NVME one. Loading table fails with the
> following diagnostics:
>
> device-mapper: table: table load rejected: including non-request-stackable devices
>
> The same kernel works with the same data drive on the SCSI interface.
> NVME-backed dm verity works with just this commit reverted.
>
> I believe the presence of the immutable partition is used as an indicator
> of special case NVME configuration and if the data device's name starts
> with "nvme" the code tries to switch the target type to
> DM_TYPE_NVME_BIO_BASED (drivers/md/dm-table.c lines 1003-1010).
>
> The special NVME optimization case was removed in
> 5.10 by commit 9c37de297f6590937f95a28bec1b7ac68a38618f, so only 5.4 is
> affected.
>
Why wouldn't 4.9, 4.14, and 4.19 also be affected here? Should I also
just queue up 9c37de297f65 ("dm: remove special-casing of bio-based
immutable singleton target on NVMe") to those older kernels? If so,
have you tested this and verified that it worked?
thanks,
greg k-h
