Re: [PATCH] btrfs: add error messages to all unrecognized mount options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 07, 2022 at 05:07:55PM +0530, Anand Jain wrote:
> 
> LGTM.
> Reviewed-by: Anand Jain <anand.jain@xxxxxxxxxx>
> 
> While we are on this topic-
> Not all valid mount options get printed either.

Looking at the amount of other informative messages we already print, I
think it won't be that bad to add the mount/umount messages, but it
depends on the system, there was an argument that bind mounts can make a
loot of noise in the logs.

> I sent a patch a long 
> time back [1] to fix it. If there is enough interest, I could revive it.

As was mentioned in the VFS version, other filesystems also print that
so let's do it for btrfs too. Please update and resend the patch, we may
then discuss what exactly to print, I'm not convinced we need all the
internal stats like the refcounts but it would be better to have
something for start.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux