Re: [PATCH] Input: bcm5974 - Set missing URB_NO_TRANSFER_DMA_MAP urb flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06.06.22 13:36, Mathias Nyman wrote:
> The bcm5974 driver does the allocation and dma mapping of the usb urb
> data buffer, but driver does not set the URB_NO_TRANSFER_DMA_MAP flag
> to let usb core know the buffer is already mapped.
> 
> usb core tries to map the already mapped buffer, causing a warning:
> "xhci_hcd 0000:00:14.0: rejecting DMA map of vmalloc memory"
> 
> Fix this by setting the URB_NO_TRANSFER_DMA_MAP, letting usb core
> know buffer is already mapped by bcm5974 driver

BTW @reviewers & @maintainers: this is fixing a regression, hence please
prioritize this. For details see "Prioritize work on fixing regressions"
in Documentation/process/handling-regressions.rst or
docs.kernel.org/process/handling-regressions.html .

> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>

If you need to respin this for one reason or another, could you please
add proper 'Link:' tags pointing to all reports about this issue? e.g.
like this:

 Link: https://bugzilla.kernel.org/show_bug.cgi?id=215890

These tags are important, as they allow others to look into the
backstory now and years from now. That is why they should be placed in
cases like this, as Documentation/process/submitting-patches.rst and
Documentation/process/5.Posting.rst explain in more detail.
Additionally, my regression tracking bot ‘regzbot’ relies on these tags
to automatically connect reports with patches that are posted or
committed to fix the reported issue.

> [...]

Ciao, Thorsten



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux