RE: [Intel-wired-lan] [PATCH net v2 1/2] ixgbe: fix bcast packets Rx on VF after promisc removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Olivier Matz
> Sent: Wednesday, April 6, 2022 11:53 AM
> To: netdev@xxxxxxxxxxxxxxx
> Cc: Paul Menzel <pmenzel@xxxxxxxxxxxxx>; intel-wired-lan@xxxxxxxxxx;
> stable@xxxxxxxxxxxxxxx; Jakub Kicinski <kuba@xxxxxxxxxx>; Nicolas Dichtel
> <nicolas.dichtel@xxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; David S .
> Miller <davem@xxxxxxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH net v2 1/2] ixgbe: fix bcast packets Rx on VF
> after promisc removal
> 
> After a VF requested to remove the promiscuous flag on an interface, the
> broadcast packets are not received anymore. This breaks some protocols like
> ARP.
> 
> In ixgbe_update_vf_xcast_mode(), we should keep the IXGBE_VMOLR_BAM
> bit (Broadcast Accept) on promiscuous removal.
> 
> This flag is already set by default in ixgbe_set_vmolr() on VF reset.
> 
> Fixes: 8443c1a4b192 ("ixgbe, ixgbevf: Add new mbox API xcast mode")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
> Signed-off-by: Olivier Matz <olivier.matz@xxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> index 7f11c0a8e7a9..8d108a78941b 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
> @@ -1184,9 +1184,9 @@ static int ixgbe_update_vf_xcast_mode(struct

Tested-by: Konrad Jankowski <konrad0.jankowski@xxxxxxxxx>




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux