This is a note to let you know that I've just added the patch titled
net/mlx4_en: Don't configure the HW vxlan parser when vxlan offloading isn't set
to the 3.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-mlx4_en-don-t-configure-the-hw-vxlan-parser-when-vxlan-offloading-isn-t-set.patch
and it can be found in the queue-3.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From foo@baz Sat Jul 26 10:16:13 PDT 2014
From: Or Gerlitz <ogerlitz@xxxxxxxxxxxx>
Date: Wed, 2 Jul 2014 17:36:23 +0300
Subject: net/mlx4_en: Don't configure the HW vxlan parser when vxlan offloading isn't set
From: Or Gerlitz <ogerlitz@xxxxxxxxxxxx>
[ Upstream commit e326f2f13b209d56782609e833b87cb497e64b3b ]
The add_vxlan_port ndo driver code was wrongly testing whether HW vxlan offloads
are supported by the device instead of checking if they are currently enabled.
This causes the driver to configure the HW parser to conduct matching for vxlan
packets but since no steering rules were set, vxlan packets are dropped on RX.
Fix that by doing the right test, as done in the del_vxlan_port ndo handler.
Fixes: 1b136de ('net/mlx4: Implement vxlan ndo calls')
Signed-off-by: Or Gerlitz <ogerlitz@xxxxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -2303,7 +2303,7 @@ static void mlx4_en_add_vxlan_port(struc
struct mlx4_en_priv *priv = netdev_priv(dev);
__be16 current_port;
- if (!(priv->mdev->dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_VXLAN_OFFLOADS))
+ if (priv->mdev->dev->caps.tunnel_offload_mode != MLX4_TUNNEL_OFFLOAD_MODE_VXLAN)
return;
if (sa_family == AF_INET6)
Patches currently in stable-queue which might be from ogerlitz@xxxxxxxxxxxx are
queue-3.15/net-mlx4_en-don-t-configure-the-hw-vxlan-parser-when-vxlan-offloading-isn-t-set.patch
queue-3.15/net-mlx4_core-fix-the-error-flow-when-probing-with-invalid-vf-configuration.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html