On 5/30/22, David Laight <David.Laight@xxxxxxxxxx> wrote: > From: Eric Biggers >> Sent: 28 May 2022 18:20 >> >> On Sat, May 28, 2022 at 11:57:01AM +0200, Jason A. Donenfeld wrote: >> > > Also, the wrong value is being passed for the 'inc' argument. >> > >> > Are you sure? Not sure I'm seeing what you are on first glance. >> >> Yes, 'inc' is the increment amount per block. It needs to always be >> BLAKE2S_BLOCK_SIZE unless a partial block is being processed. > > IIRC it isn't used for partial blocks. > Which rather begs the question as to why it is a parameter at all. Again, with blake2s, please send a patch if you think there's an improvement to be made. In this case, I don't think you're right. See blake2s_final. Jason
