On Sun, 22 May 2022 12:34:06 -0400 Sasha Levin <sashal@xxxxxxxxxx> wrote: > On Fri, May 20, 2022 at 02:05:15PM -0500, Glenn Washburn wrote: > >Resending this because stable@xxxxxxxxxxxxxxx using wrong header field. > >Apologize for duplicates. > > > >On Thu, 19 May 2022 09:52:07 -0400 > >Sasha Levin <sashal@xxxxxxxxxx> wrote: > > > >> This is a note to let you know that I've just added the patch titled > >> > >> um: port_user: Improve error handling when port-helper is not found > >> > >> to the 5.17-stable tree which can be found at: > >> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > >> > >> The filename of the patch is: > >> um-port_user-improve-error-handling-when-port-helper.patch > >> and it can be found in the queue-5.17 subdirectory. > >> > >> If you, or anyone else, feels it should not be added to the stable tree, > >> please let <stable@xxxxxxxxxxxxxxx> know about it. > > > >First, I should say that I'm not familiar with the process so I'm > >likely to be wrong on any number of things. Second I'm the author of > >this patch and I would like to see this included in the stable trees. > >However, it appears to me that there is a problem in including just this > >patch, as it depends on a previous patch which does not appear to be > >applied[1]. > > Right, I've dropped it. > > >The the afore mentioned patch that this patch depends on "env" is > >declared and set. Without it, I'd expect this to fail to compile. As > >such, I may be wrong in that the dependent patch was not already > >included because I'd expect there to have been a compile test prior to > >this patch getting to this phase. > > > >My suspicion is that the stable trees try to not include new > >functionality, which the missing patch may have been considered to have > >done, and thus was not included. If its deemed undesirable to include > >the missing patch, this "if" block can be removed. Although, I think > >the missing patch is valuable enough to include. > > > >The above goes for all the stable branches that this patch is set to be > >included in. > > Could you provide a list of patches that are needed here? Sore. Strictly speaking, the only dependency is the patch mentioned[1]. Although, I'd suggest picking up this patch[2] that's related to improving messaging on error conditions. I'm also unsure if the provided links are what you're looking for in terms of how to specify patches for you. Let me know more specifically if this doesn't suffice. Glenn [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.18-rc7&id=db8109a8bb4a4b31e7f630d7667749d62ee4a087 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.18-rc7&id=82017457957a550d7d00dde419435dd74a890887
