[patch 01/10] coredump: fix the setting of PF_DUMPCORE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Silesh C V <svellattu@xxxxxxxxxx>
Subject: coredump: fix the setting of PF_DUMPCORE

commit 079148b91 ("coredump: factor out the setting of PF_DUMPCORE")
cleaned up the setting of PF_DUMPCORE by removing it from all the
linux_binfmt->core_dump() and moving it to zap_threads().But this ended up
clearing all the previously set flags.  This causes issues during core
generation when tsk->flags is checked again (eg.  for PF_USED_MATH to dump
floating point registers).  Fix this.

Signed-off-by: Silesh C V <svellattu@xxxxxxxxxx>
Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>
Cc: Mandeep Singh Baines <msb@xxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>	[3.10+]
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 fs/coredump.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/coredump.c~coredump-fix-the-setting-of-pf_dumpcore fs/coredump.c
--- a/fs/coredump.c~coredump-fix-the-setting-of-pf_dumpcore
+++ a/fs/coredump.c
@@ -306,7 +306,7 @@ static int zap_threads(struct task_struc
 	if (unlikely(nr < 0))
 		return nr;
 
-	tsk->flags = PF_DUMPCORE;
+	tsk->flags |= PF_DUMPCORE;
 	if (atomic_read(&mm->mm_users) == nr + 1)
 		goto done;
 	/*
_
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]