The patch titled
Subject: slab_common: fix the check for duplicate slab names
has been added to the -mm tree. Its filename is
slab_common-fix-the-check-for-duplicate-slab-names.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/slab_common-fix-the-check-for-duplicate-slab-names.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/slab_common-fix-the-check-for-duplicate-slab-names.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Subject: slab_common: fix the check for duplicate slab names
3e374919b314 ("slab_common: Do not check for duplicate slab names") is
supposed to fix the problem where kmem_cache_create incorrectly reports
duplicate cache name and fails. The problem is described in the header of
that patch.
However, the patch doesn't really fix the problem because of these
reasons:
* the logic to test for debugging is reversed. It was intended to perform
the check only if slub debugging is enabled (which implies that caches
with the same parameters are not merged). Therefore, there should be
#if !defined(CONFIG_SLUB) || defined(CONFIG_SLUB_DEBUG_ON)
The current code has the condition reversed and performs the test if
debugging is disabled.
* slub debugging may be enabled or disabled based on kernel command line,
CONFIG_SLUB_DEBUG_ON is just the default settings. Therefore the test
based on definition of CONFIG_SLUB_DEBUG_ON is unreliable.
This patch fixes the problem by removing the test
"!defined(CONFIG_SLUB_DEBUG_ON)". Therefore, duplicate names are never
checked if the SLUB allocator is used.
Note to stable kernel maintainers: when backporint this patch, please
backport also the patch 3e374919b314f20e2a04f641ebc1093d758f66a4.
Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxx>
Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
Acked-by: Christoph Lameter <cl@xxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> [3.6+]
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/slab_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/slab_common.c~slab_common-fix-the-check-for-duplicate-slab-names mm/slab_common.c
--- a/mm/slab_common.c~slab_common-fix-the-check-for-duplicate-slab-names
+++ a/mm/slab_common.c
@@ -55,7 +55,7 @@ static int kmem_cache_sanity_check(const
continue;
}
-#if !defined(CONFIG_SLUB) || !defined(CONFIG_SLUB_DEBUG_ON)
+#if !defined(CONFIG_SLUB)
if (!strcmp(s->name, name)) {
pr_err("%s (%s): Cache name already exists.\n",
__func__, name);
_
Patches currently in -mm which might be from mpatocka@xxxxxxxxxx are
origin.patch
slab_common-fix-the-check-for-duplicate-slab-names.patch
linux-next.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html