Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@xxxxxxxxxx>: On Thu, 5 May 2022 16:31:01 -0700 you wrote: > Using min_t(int, ...) as a potential array index implies to the compiler > that negative offsets should be allowed. This is not the case, though. > Replace "int" with "unsigned int". Fixes the following warning exposed > under future CONFIG_FORTIFY_SOURCE improvements: > > In file included from include/linux/string.h:253, > from include/linux/bitmap.h:11, > from include/linux/cpumask.h:12, > from include/linux/smp.h:13, > from include/linux/lockdep.h:14, > from include/linux/rcupdate.h:29, > from include/linux/rculist.h:11, > from include/linux/pid.h:5, > from include/linux/sched.h:14, > from include/linux/delay.h:23, > from drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:35: > drivers/net/ethernet/chelsio/cxgb4/t4_hw.c: In function 't4_get_raw_vpd_params': > include/linux/fortify-string.h:46:33: warning: '__builtin_memcpy' pointer overflow between offset 29 and size [2147483648, 4294967295] [-Warray-bounds] > 46 | #define __underlying_memcpy __builtin_memcpy > | ^ > include/linux/fortify-string.h:388:9: note: in expansion of macro '__underlying_memcpy' > 388 | __underlying_##op(p, q, __fortify_size); \ > | ^~~~~~~~~~~~~ > include/linux/fortify-string.h:433:26: note: in expansion of macro '__fortify_memcpy_chk' > 433 | #define memcpy(p, q, s) __fortify_memcpy_chk(p, q, s, \ > | ^~~~~~~~~~~~~~~~~~~~ > drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:2796:9: note: in expansion of macro 'memcpy' > 2796 | memcpy(p->id, vpd + id, min_t(int, id_len, ID_LEN)); > | ^~~~~~ > include/linux/fortify-string.h:46:33: warning: '__builtin_memcpy' pointer overflow between offset 0 and size [2147483648, 4294967295] [-Warray-bounds] > 46 | #define __underlying_memcpy __builtin_memcpy > | ^ > include/linux/fortify-string.h:388:9: note: in expansion of macro '__underlying_memcpy' > 388 | __underlying_##op(p, q, __fortify_size); \ > | ^~~~~~~~~~~~~ > include/linux/fortify-string.h:433:26: note: in expansion of macro '__fortify_memcpy_chk' > 433 | #define memcpy(p, q, s) __fortify_memcpy_chk(p, q, s, \ > | ^~~~~~~~~~~~~~~~~~~~ > drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:2798:9: note: in expansion of macro 'memcpy' > 2798 | memcpy(p->sn, vpd + sn, min_t(int, sn_len, SERNUM_LEN)); > | ^~~~~~ > > [...] Here is the summary with links: - [v2] net: chelsio: cxgb4: Avoid potential negative array offset https://git.kernel.org/netdev/net/c/1c7ab9cd98b7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html