From: Hu <yadi.hu@xxxxxxxxxxxxx>
b9cd18de4db3c9ffa7e17b0dc0ca99ed5aa4d43a upstream
The 'sysret' fastpath does not correctly restore even all
regular registers, much less any segment registers or reflags
values. That is very much part of why it's faster than 'iret'.
Normally that isn't a problem, because the normal ptrace()
interface catches the process using the signal handler infrastructure,
which always returns with an iret. However, some paths can get
caught using ptrace_event() instead of the signal path, and for
those we need to make sure that we aren't going to return to user
space using 'sysret'.
Otherwise the modifications that may have been done to the register
set by the tracer wouldn't necessarily take effect. Fix it by forcing IRET
path by setting TIF_NOTIFY_RESUME from arch_ptrace_stop_needed(),which
is invoked from ptrace_stop().
Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
Reported-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>
Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Hu <yadi.hu@xxxxxxxxxxxxx>
---
arch/x86/include/asm/ptrace.h | 17 +++++++++++++++++
include/linux/ptrace.h | 3 +++
2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/ptrace.h b/arch/x86/include/asm/ptrace.h
index 69a686a..a520572 100644
--- a/arch/x86/include/asm/ptrace.h
+++ b/arch/x86/include/asm/ptrace.h
@@ -283,6 +283,23 @@ static inline unsigned long regs_get_kernel_stack_nth(struct pt_regs *regs,
#define ARCH_HAS_USER_SINGLE_STEP_INFO
+/*
+ * When hitting ptrace_stop(), we cannot return using SYSRET because
+ * that does not restore the full CPU state, only a minimal set. The
+ * ptracer can change arbitrary register values, which is usually okay
+ * because the usual ptrace stops run off the signal delivery path which
+ * forces IRET; however, ptrace_event() stops happen in arbitrary places
+ * in the kernel and don't force IRET path.
+ *
+ * So force IRET path after a ptrace stop.
+ */
+#define arch_ptrace_stop_needed(code, info) \
+({ \
+ set_thread_flag(TIF_NOTIFY_RESUME); \
+ false; \
+})
+
+
struct user_desc;
extern int do_get_thread_area(struct task_struct *p, int idx,
struct user_desc __user *info);
diff --git a/include/linux/ptrace.h b/include/linux/ptrace.h
index dae0e5a..d5bacbb 100644
--- a/include/linux/ptrace.h
+++ b/include/linux/ptrace.h
@@ -326,6 +326,9 @@ static inline void user_single_step_siginfo(struct task_struct *tsk,
* calling arch_ptrace_stop() when it would be superfluous. For example,
* if the thread has not been back to user mode since the last stop, the
* thread state might indicate that nothing needs to be done.
+ *
+ * This is guaranteed to be invoked once before a task stops for ptrace and
+ * may include arch-specific operations necessary prior to a ptrace stop.
*/
#define arch_ptrace_stop_needed(code, info) (0)
#endif
--
1.7.0.5
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html