Le 29/04/2022 à 16:31, David Ahern a écrit :
> On 4/29/22 2:20 AM, Nicolas Dichtel wrote:
>> When ping_group_range is updated, 'ping' uses the DGRAM ICMP socket,
>> instead of an IP raw socket. In this case, 'ping' is unable to bind its
>> socket to a local address owned by a vrflite.
>>
>> Before the patch:
>> $ sysctl -w net.ipv4.ping_group_range='0 2147483647'
>> $ ip link add blue type vrf table 10
>> $ ip link add foo type dummy
>> $ ip link set foo master blue
>> $ ip link set foo up
>> $ ip addr add 192.168.1.1/24 dev foo
>> $ ip vrf exec blue ping -c1 -I 192.168.1.1 192.168.1.2
>> ping: bind: Cannot assign requested address
>>
>> CC: stable@xxxxxxxxxxxxxxx
>> Fixes: 1b69c6d0ae90 ("net: Introduce L3 Master device abstraction")
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
>> ---
>>
>> v1 -> v2:
>> add the tag "Cc: stable@xxxxxxxxxxxxxxx" for correct stable submission
>>
>> net/ipv4/ping.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>
> please add a test case to fcnal-test.sh. Does ipv6 work ok?
Indeed, ipv6 is missing.
I will add some test cases.
Modifying the sysctl before the vrf tests produce a lot of failures:
With VRF
SYSCTL: net.ipv4.raw_l3mdev_accept=1
SYSCTL: net.ipv4.ping_group_range=0 2147483647
TEST: ping out, VRF bind - ns-B IP [ OK ]
TEST: ping out, device bind - ns-B IP [FAIL]
TEST: ping out, vrf device + dev address bind - ns-B IP [FAIL]
TEST: ping out, vrf device + dev address bind - ns-B IP [FAIL]
TEST: ping out, vrf device + vrf address bind - ns-B IP [FAIL]
TEST: ping out, VRF bind - ns-B loopback IP [ OK ]
TEST: ping out, device bind - ns-B loopback IP [FAIL]
TEST: ping out, vrf device + dev address bind - ns-B loopback IP [FAIL]
TEST: ping out, vrf device + dev address bind - ns-B loopback IP [FAIL]
TEST: ping out, vrf device + vrf address bind - ns-B loopback IP [FAIL]
Regards,
Nicolas
