On Tue, Apr 26, 2022 at 10:38 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > > On Tue, Apr 26, 2022 at 10:37:17PM +0800, Yongji Xie wrote: > > On Tue, Apr 26, 2022 at 10:18 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > > > > > > On Tue, Apr 26, 2022 at 10:02:02PM +0800, Yongji Xie wrote: > > > > > This should not be needed, when your module is unloaded, all devices it > > > > > handled should be properly removed by it. > > > > > > > > > > > > > I see. But it's not easy to achieve that currently. Maybe we need > > > > something like DEVICE_NEEDS_RESET support in virtio core. > > > > > > Not sure what the connection is. > > > > > > > If we want to force remove all working vduse devices during module > > unload, we might need to send a DEVICE_NEEDS_RESET notification to > > device driver to do some cleanup before, e.g., return error for all > > inflight I/Os. > > > > Thanks, > > Yongji > > IMHO DEVICE_NEEDS_RESET won't help much with that, it's more in > case device is still there but needs a reset to start working. > OK, we just want a reset without restarting work in our case. Looks like we might need some other mechanism to achieve that. Thanks, Yongji
