On Mon, Apr 18, 2022 at 12:03:32PM +0300, Dragos-Marian Panait wrote:
> From: Hangyu Hua <hbh25y@xxxxxxxxx>
>
> commit 3d3925ff6433f98992685a9679613a2cc97f3ce2 upstream.
>
> There is no need to call dev_kfree_skb() when usb_submit_urb() fails
> because can_put_echo_skb() deletes original skb and
> can_free_echo_skb() deletes the cloned skb.
>
> Fixes: 0024d8ad1639 ("can: usb_8dev: Add support for USB2CAN interface from 8 devices")
> Link: https://lore.kernel.org/all/20220311080614.45229-1-hbh25y@xxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Hangyu Hua <hbh25y@xxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> [DP: adjusted params of can_free_echo_skb() for 4.19 stable]
> Signed-off-by: Dragos-Marian Panait <dragos.panait@xxxxxxxxxxxxx>
> ---
> drivers/net/can/usb/usb_8dev.c | 30 ++++++++++++++----------------
> 1 file changed, 14 insertions(+), 16 deletions(-)
You sent this twice, why? What is the difference between the two?
Also, why not cc: the maintainers and developers involved? Please do
so.
thanks,
greg k-h
