Re: [PATCH 5.17] iwlwifi: yoyo: fix DBGI_SRAM ini dump header.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 13, 2022 at 11:06:00AM +0300, Luca Coelho wrote:
> From: Rotem Saado <rotem.saado@xxxxxxxxx>
> 
> commit 34bc27783a31a05d2fb987d8fa0f4f702efd0359 upstream.
> 
> DBGI SRAM is new type of monitor, therefore it should be
> dump as monitor type with ini dump monitor header.
> 
> Signed-off-by: Rotem Saado <rotem.saado@xxxxxxxxx>
> Fixes: 89639e06d0f3 ("iwlwifi: yoyo: support for new DBGI_SRAM region")
> Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
> Link: https://lore.kernel.org/r/iwlwifi.20220129105618.6c31f6a2dcfc.If311c1d548bc5f7157a449e848ea01f71f5592eb@changeid
> Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
> ---
>  .../net/wireless/intel/iwlwifi/cfg/22000.c    |  6 ++++
>  drivers/net/wireless/intel/iwlwifi/fw/dbg.c   | 29 +++++++++++++++++--
>  .../net/wireless/intel/iwlwifi/iwl-config.h   |  1 +
>  drivers/net/wireless/intel/iwlwifi/iwl-prph.h |  2 ++
>  4 files changed, 36 insertions(+), 2 deletions(-)

Please always test-build your patches before sending them.  This broke
the build:

drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2282:33: error: initialization of ‘void * (*)(struct iwl_fw_runtime *, struct iwl_dump_ini_region_data *, void *)’ from incompatible pointer type ‘void * (*)(struct iwl_fw_runtime *, struct iwl_dump_ini_region_data *, void *, u32)’ {aka ‘void * (*)(struct iwl_fw_runtime *, struct iwl_dump_ini_region_data *, void *, unsigned int)’} [-Werror=incompatible-pointer-types]
 2282 |                 .fill_mem_hdr = iwl_dump_ini_mon_dbgi_fill_header,
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

{sigh}

Odds are your other backports will too, so I'm going to ignore them as
well and wait for working ones.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux