On Thu, Apr 07, 2022 at 02:16:42PM -0600, dann frazier wrote:
> This reverts commit 9cc25e8529d567e08da98d11f092b21449763144.
>
> This patch was shown to introduce a regression:
>
> # devlink dev param show pci/0000:24:00.0 name flow_steering_mode
> pci/0000:24:00.0:
> name flow_steering_mode type driver-specific
> values:
>
> (flow steering mode description is missing beneath "values:")
>
> # devlink dev param set pci/0000:24:00.0 name flow_steering_mode value smfs cmode runtime
> Segmentation fault (core dumped)
>
> and also with upstream iproute
> # ./iproute2/devlink/devlink dev param set pci/0000:24:00.0 name flow_steering_mode value smfs cmode runtime
> Configuration mode not supported
>
> Note: Instead of reverting, we could instead also backport commit cf530217408e
> ("devlink: Notify users when objects are accessible"). However, that makes
> changes to core devlink code that I'm not sure are suitable for a stable
> backport.
>
> Signed-off-by: dann frazier <dann.frazier@xxxxxxxxxxxxx>
Now queued up, thanks.
greg k-h
