3.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jean Sacren <sakiwit@xxxxxxxxx> commit ce9ccb17ef5b5088172f46dd246c92523fd3a524 upstream. The commit 6c167f582ea9 ("i40e: Refactor and cleanup i40e_open(), adding i40e_vsi_open()") introduced a new function i40e_vsi_open() with the regression by a typo. Due to the commit, the wrong error code would be passed to i40e_open(). Fix this error in i40e_vsi_open() by turning the macro into a negative value so that i40e_open() could return the pertinent error code correctly. Fixes: 6c167f582ea9 ("i40e: Refactor and cleanup i40e_open(), adding i40e_vsi_open()") Signed-off-by: Jean Sacren <sakiwit@xxxxxxxxx> Tested-by: Kavindya Deegala <kavindya.s.deegala@xxxxxxxxx> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -4310,7 +4310,7 @@ int i40e_vsi_open(struct i40e_vsi *vsi) goto err_setup_rx; if (!vsi->netdev) { - err = EINVAL; + err = -EINVAL; goto err_setup_rx; } snprintf(int_name, sizeof(int_name) - 1, "%s-%s", -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html