On Wed, Apr 06, 2022 at 10:11:29AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 05, 2022 at 11:24:13PM -0400, Steven Rostedt wrote: > > On Tue, 5 Apr 2022 23:08:12 -0400 > > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > > Here's a thought, if you decide to backport a patch to stable, and you see > > > that there's another commit with a "Fixes" tag to the automatically > > > selected commit. DO NOT BACKPORT IF THE FIXES PATCH FAILS TO GO BACK TOO! > > > > Seriously. This should be the case for *all* backported patches, not just > > the AUTOSEL ones. > > > > Otherwise you are backporting a commit to "stable" that is KNOWN TO BE > > BROKEN! > > My scripts usually do catch this, let me go see what went wrong... Ok, my fault, my scripts _did_ catch this, but I ignored it as it was filled with other noise. I've now queued this commit up. thanks for catching this and sorry for missing it the first time around. greg k-h
