On Tue, Apr 05, 2022 at 09:18:32AM +0200, Greg Kroah-Hartman wrote: > From: Marc Zyngier <maz@xxxxxxxxxx> > > commit 825da4e9cec68713fbb02dc6f71fe1bf65fe8050 upstream. > > Commit c7a75d07827a ("PCI: xgene: Fix IB window setup") tried to > fix the damages that 6dce5aa59e0b ("PCI: xgene: Use inbound resources > for setup") caused, but actually didn't improve anything for some > plarforms (at least Mustang and m400 are still broken). > > Given that 6dce5aa59e0b has been reverted, revert this patch as well, > restoring the PCIe support on XGene to its pre-5.5, working state. > > Link: https://lore.kernel.org/r/YjN8pT5e6/8cRohQ@xps13.dannf > Link: https://lore.kernel.org/r/20220321104843.949645-3-maz@xxxxxxxxxx > Fixes: c7a75d07827a ("PCI: xgene: Fix IB window setup") > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx> > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Cc: Rob Herring <robh@xxxxxxxxxx> > Cc: Toan Le <toan@xxxxxxxxxxxxxxxxxxxxxx> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > Cc: Krzysztof Wilczyński <kw@xxxxxxxxx> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Cc: Stéphane Graber <stgraber@xxxxxxxxxx> > Cc: dann frazier <dann.frazier@xxxxxxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > drivers/pci/controller/pci-xgene.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi Greg, I don't think it makes sense to apply this to 5.10.y, 5.15.y & 5.16.y w/o also applying a backport of 1874b6d7ab1, because without that we will regress support for Stéphane's X-Gene2-based systems. The backport of 1874b6d7ab1 was rejected for these trees because it doesn't apply cleanly, but I've just submitted new versions that do. -dann