On Wed, Mar 30, 2022 at 03:34:34AM -0400, Joshua Freedman wrote: > Hi, I noticed my audio and mic stopped working on my yoga c930 on 5.16.12 > and newer. 5.16.11 was ok. On 5.16.12 and above I get a dummy output and > no mic. > > Anything we can do about that? Thanks. > > I'm not a git guy so I just looked at the changlogs and this was the only > audio one in 5.16.12. I could be wrong in the ID though. > > commit 6b0d719ffed1c21c1a2e473301fd95f78cd35c9e > Author: Siarhei Volkau <lis8215@xxxxxxxxx> > Date: Sat Feb 5 20:18:49 2022 +0300 > > clk: jz4725b: fix mmc0 clock gating > > commit 2f0754f27a230fee6e6d753f07585cee03bedfe3 upstream. > > The mmc0 clock gate bit was mistakenly assigned to "i2s" clock. > You can find that the same bit is assigned to "mmc0" too. > It leads to mmc0 hang for a long time after any sound activity > also it prevented PM_SLEEP to work properly. > I guess it was introduced by copy-paste from jz4740 driver > where it is really controls I2S clock gate. > > Fixes: 226dfa4726eb ("clk: Add Ingenic jz4725b CGU driver") > Signed-off-by: Siarhei Volkau <lis8215@xxxxxxxxx> > Tested-by: Siarhei Volkau <lis8215@xxxxxxxxx> > Reviewed-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Link: https://lore.kernel.org/r/20220205171849.687805-2-lis8215@xxxxxxxxx > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > If you revert this does your machine work properly? Is 5.17 also broken for you due to this change, or does it work properly? thanks, greg k-h