Re: [PATCH v7 0/4] mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ahmad-san,

On 2022/03/28 19:50, Ahmad Fatoum wrote:
Hello Tokunori-san,

On 23.03.22 18:04, Tokunori Ikegami wrote:
Since commit dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to
check correct value") buffered writes fail on S29GL064N. This is
because, on S29GL064N, reads return 0xFF at the end of DQ polling for
write completion, where as, chip_good() check expects actual data
written to the last location to be returned post DQ polling completion.
Fix is to revert to using chip_good() for S29GL064N which only checks
for DQ lines to settle down to determine write completion.

Fixes: dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to check correct value")
Signed-off-by: Tokunori Ikegami <ikegami.t@xxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Link: https://lore.kernel.org/r/b687c259-6413-26c9-d4c9-b3afa69ea124@xxxxxxxxxxxxxx/
For this series,

Tested-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
Thank you for your support.

Thanks a lot for taking care of this. Could you keep me Cc'd
on future revisions? Convention is via a Reported-by tag
in the regression fix.

Sorry for this. Yes I will do cc on next time and also consider to add the Reported-by tag also.

Regards,
Ikegami


Cheers,
Ahmad


Tokunori Ikegami (4):
   mtd: cfi_cmdset_0002: Move and rename
     chip_check/chip_ready/chip_good_for_write
   mtd: cfi_cmdset_0002: Use chip_ready() for write on S29GL064N
   mtd: cfi_cmdset_0002: Add S29GL064N ID definition
   mtd: cfi_cmdset_0002: Rename chip_ready variables

  drivers/mtd/chips/cfi_cmdset_0002.c | 112 ++++++++++++++--------------
  include/linux/mtd/cfi.h             |   1 +
  2 files changed, 55 insertions(+), 58 deletions(-)





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux