On Sun, 27 Mar 2022 21:58:05 +0300, Vladimir Oltean wrote:
> On Sun, Mar 27, 2022 at 01:55:47PM +0800, Xiaomeng Tong wrote:
> > The bug is here:
> > return rule;
> >
> > The list iterator value 'rule' will *always* be set and non-NULL
> > by list_for_each_entry(), so it is incorrect to assume that the
> > iterator value will be NULL if the list is empty or no element
> > is found.
> >
> > To fix the bug, return 'rule' when found, otherwise return NULL.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: ae7a5aff783c7 ("net: dsa: bcm_sf2: Keep copy of inserted rules")
> > Signed-off-by: Xiaomeng Tong <xiam0nd.tong@xxxxxxxxx>
> > ---
>
> The change looks correct, but from a process standpoint for next time
> (a) you should have copied Florian, the driver's maintainer (which I did now)
> who appears on the top of the list in the output of ./get_maintainer.pl
> (b) networking bugfixes that apply to the "net" tree shouldn't need
> stable@xxxxxxxxxxxxxxx copied, instead just target the patch against
> the https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
> tree and mark the subject prefix as "[PATCH net]".
>
> Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>
Thank you for your patient review and good suggestion, i got it.
I'm sorry I forgot to copy Florian.
--
Xiaomeng tong
