Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM imbalance on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----原始邮件-----
> 发件人: "Pavel Machek" <pavel@xxxxxxx>
> 发送时间: 2022-02-25 06:39:08 (星期五)
> 收件人: "Sasha Levin" <sashal@xxxxxxxxxx>
> 抄送: linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, "Yongzhi Liu" <lyz_cs@xxxxxxxxxx>, "Vinod Koul" <vkoul@xxxxxxxxxx>, christophe.jaillet@xxxxxxxxxx, arnd@xxxxxxxx, laurent.pinchart@xxxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx
> 主题: Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM imbalance on error
> 
> Hi!
> 
> > From: Yongzhi Liu <lyz_cs@xxxxxxxxxx>
> > 
> > [ Upstream commit 455896c53d5b803733ddd84e1bf8a430644439b6 ]
> > 
> > pm_runtime_get_() increments the runtime PM usage counter even
> > when it returns an error code, thus a matching decrement is needed on
> > the error handling path to keep the counter balanced.
> 
> I don't think that's right.
> 
> Notice that -ret is ignored (checked 4.4 and 5.10), so we don't
> actually abort/return error; we just printk. We'll do two
> pm_runtime_put's after the "fix".

Thank you very much for the correction. I am very sorry that I caused you unnecessary trouble because of my carelessness.
The pm_runtime_put is indeed called later in __ld_cleanup, so only printk is needed at -ret and the patch is not right.

> 
> Please drop from -stable.
> 
> Best regards,
> 								Pavel
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux