Since version 4.9.293 I have been getting this USB error when building
the kernel. m68k is too old to have USB.
cp vmlinux vmlinux.tmp
m68k-linux-strip vmlinux.tmp
Building modules, stage 2.
gzip -9c vmlinux.tmp >vmlinux.gz
MODPOST 894 modules
rm vmlinux.tmp
ERROR: "usb_hid_driver" [drivers/hid/wacom.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1251: recipe for target 'modules' failed
make: *** [modules] Error 2
Version 4.9.292 works. Running git bisect tells me:
1309eb2ef1001c4cc7e07b867ad9576d2cfeab47 is the first bad commit
commit 1309eb2ef1001c4cc7e07b867ad9576d2cfeab47
Author: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Wed Dec 1 19:35:02 2021 +0100
HID: wacom: fix problems when device is not a valid USB device
commit 720ac467204a70308bd687927ed475afb904e11b upstream.
The wacom driver accepts devices of more than just USB types, but
some code paths can cause problems if the device being controlled
is not a USB device due to a lack of checking. Add the needed
checks to ensure that the USB device accesses are only happening on
a "real" USB device, and not one on some other bus.
Cc: Jiri Kosina <jikos@xxxxxxxxxx>
Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
Cc: linux-input@xxxxxxxxxxxxxxx
Cc: stable@xxxxxxxxxxxxxxx
Tested-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
Link:
https://lore.kernel.org/r/20211201183503.2373082-2-gregkh@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
drivers/hid/wacom_sys.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
Attachment:
config
Description: Binary data
Attachment:
pgpsvq7u4NALI.pgp
Description: OpenPGP digital signature
