On Mon, Jan 31, 2022 at 11:36:32AM -0800, Mat Martineau wrote:
> On Mon, 31 Jan 2022, Greg Kroah-Hartman wrote:
>
> > From: Paolo Abeni <pabeni@xxxxxxxxxx>
> >
> > [ Upstream commit 86e39e04482b0aadf3ee3ed5fcf2d63816559d36 ]
>
> Hi Greg -
>
> Please drop this from the stable queue for both 5.16 and 5.15. It wasn't
> intended for backporting and we haven't checked for dependencies with other
> changes in this part of MPTCP subsystem.
>
> In the mptcp tree we make sure to add Fixes: tags on every patch we think is
> eligible for the -stable tree. I know you're sifting through a lot of
> patches from subsystems that end up with important fixes arriving from the
> "-next" branches, and it seems like the scripts scooped up several MPTCP
> patches this time around that don't meet the -stable rules.
I think these were needed due to 8e9eacad7ec7 ("mptcp: fix msk traversal
in mptcp_nl_cmd_set_flags()") which you did tag with a "Fixes:" tag,
right? Without these other commits, that one does not apply and it
looks like it should go into 5.15.y and 5.16.y.
Note, just putting a "Fixes:" tag does not guarantee if a commit will go
into a stable tree. Please use the correct "Cc: stable@xxxxxxxxxxxxxxx"
tag as the documentation asks for.
I'll go drop all of these mptcp patches, including 8e9eacad7ec7 ("mptcp:
fix msk traversal in mptcp_nl_cmd_set_flags()") for now. If you want
them added back in, please let us know.
thanks,
greg k-h
