Re: [PATCH] ipvs: Fix panic due to non-linear skb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 03, 2014 at 11:28:16AM +0200, Peter Christensen wrote:
> On Thu, 3 Jul 2014 11:21:04 +0200
> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> 
> > On Thu, Jul 03, 2014 at 11:16:52AM +0200, Peter Christensen wrote:
> > > On Thu, 3 Jul 2014 10:21:19 +0200
> > > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > > 
> > > > On Thu, Jul 03, 2014 at 09:00:57AM +0200, Peter Christensen wrote:
> > > > > On Wed, 18 Jun 2014 11:44:01 +0200
> > > > > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > > > > 
> > > > > > From: Peter Christensen <pch@xxxxxxxxxxxx>
> > > > > > 
> > > > > > [ Upstream commit f44a5f45f544561302e855e7bd104e5f506ec01b ]
> > > > > > 
> > > > > > Receiving a ICMP response to an IPIP packet in a non-linear
> > > > > > skb could cause a kernel panic in __skb_pull.
> > > > > > 
> > > > > > The problem was introduced in
> > > > > > commit f2edb9f7706dcb2c0d9a362b2ba849efe3a97f5e ("ipvs:
> > > > > > implement passive PMTUD for IPIP packets").
> > > > > > 
> > > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.10.x
> > > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.12.x
> > > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.14.x
> > > > > > Signed-off-by: Peter Christensen <pch@xxxxxxxxxxxx>
> > > > > > Acked-by: Julian Anastasov <ja@xxxxxx>
> > > > > > Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > I was wondering what the status of this patch was, since it
> > > > > hasn't been included in the stable queue yet.
> > > > 
> > > > I'll be sending a request for this and another Netfilter/IPVS
> > > > patches soon.
> > > > 
> > > > I don't see this patch yet in:
> > > > 
> > > > http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/
> > > > 
> > > > since it's updated to -rc2, and I think it's the reference tree.
> > > 
> > > The patch was added 2014-05-26, just after 3.15-rc7:
> > > 
> > > http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/net/netfilter/ipvs/ip_vs_core.c
> > 
> > Ah, it took me a while to notice. So I already sent this to Greg.
> > 
> > Then, please don't be pushie and let Greg takes his time. Rushing is
> > not good.
> > 
> > Thank you.
> 
> My apologies.
> 
> Greg's work flow isn't entirely clear to me, so I didn't know what to
> expect.

Hm, for some reason I totally missed this patch, I don't know how it
happened.  Thanks for the reminder, I've now queues it up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]