On Mon, Jan 24, 2022 at 04:34:31PM +0100, Ben Hutchings wrote: > From: Dave Airlie <airlied@xxxxxxxxxx> > > commit 5de5b6ecf97a021f29403aa272cb4e03318ef586 upstream. > > This is confusing, and from my reading of all the drivers only > nouveau got this right. > > Just make the API act under driver control of it's own allocation > failing, and don't call destroy, if the page table fails to > create there is nothing to cleanup here. > > (I'm willing to believe I've missed something here, so please > review deeply). > > Reviewed-by: Christian König <christian.koenig@xxxxxxx> > Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx> > Link: https://patchwork.freedesktop.org/patch/msgid/20200728041736.20689-1-airlied@xxxxxxxxx > [bwh: Backported to 4.14: > - Drop change in ttm_sg_tt_init() > - Adjust context] > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/nouveau/nouveau_sgdma.c | 9 +++------ > drivers/gpu/drm/ttm/ttm_tt.c | 2 -- > 2 files changed, 3 insertions(+), 8 deletions(-) Now queued up, thanks for the backport! greg k-h
