Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 20.01.22 um 22:28 schrieb Zack Rusin:
On Thu, 2022-01-20 at 11:00 +0100, Thomas Zimmermann wrote:

If that works, would you consider protecting pci_request_region()
with
    #if not defined(CONFIG_FB_SIMPLE)
    #endif

with a FIXME comment?

Yes, I think that's a good compromise. I'll respin the patch with
that.

Before you do that, I have one more patch for you to try. It's all
the
changes as before, but now fbdev hot-unplugs the underlying platform
device from the device hierarchy. The BOOTFB will not consume parts
of
vmwgfx's display memory range any longer. It's now the same behavior
as
with simpledrm.

This works for me with simplefb and efifb on i915 hardware.

Yea, that works for me too. Both with simpledrm and simplefb. The patch
looks good too.

Do you think you'll be able to get this in stable kernels? If not I'll
still need something for vmwgfx to make kernels between 5.15 and
whenever this patch gets in boot with fb.

I'll prepare a patchset with these changes. The actual fix is the change to fbmem.c. This one should go to stable and should be easy to backport. All the other patches are mostly for correctness and can go to drm-misc-next only.

Can I add your Tested-by tag to the patches?

Best regards
Thomas


z

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux