Re: [PATCH for stable 5.x] rcu: Tighten rcu_advance_cbs_nowake() checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 20, 2022 at 08:26:54PM +0100, Guillaume Morin wrote:
> On 20 Jan 11:16, Paul E. McKenney wrote:
> > On Thu, Jan 20, 2022 at 07:55:01PM +0100, Guillaume Morin wrote:
> > > I believe commit 614ddad17f22a22e035e2ea37a04815f50362017 (slated for
> > > 5.17) should be queued for all 5.4+ stable branches as it fixes a
> > > serious lockup bug. FWIW I have verified it applies cleanly on all 4
> > > branches.
> > > 
> > > Does that make sense to you?
> > 
> > From a quick glance at v5.4, it looks quite plausible to me.
> > 
> > I do suggest that you try building and testing, given that the hardware's
> > idea of what is plausible overrides that of either of us.  ;-)
> 
> We've had a few dozens lockups on 5.4 and 5.10 due to this bug (what
> lead me to write to you back in Sep). The original bugzilla report is on
> 5.4 as well, see https://bugzilla.kernel.org/show_bug.cgi?id=208685. So
> I am positive that the issue is reachable in both kernels.
> 
> Also I do know for sure it fixes the problem for 5.10. I don't have a
> test rig anymore for 5.4. But considering we know it's reachable with
> 5.4, I think the patch should be applied for 5.4+. Obviously, you're the
> expert here though.

Au contraire!  I do not claim much expertise on -stable validation.

If it was me, I would run a quick touch-test like this from the top-level
directory of the Linux-kernel source tree on a qemu/KVM-capable system:

	tools/testing/selftests/rcutorture/bin/kvm.sh --cpus N --duration 10 --configs "TREE01 TREE04"

Where "N" is replaced by the number of CPUs on your system, which should
preferably be at least eight.

This will take somewhere between 15 minutes and an hour to run, depending
on your system.

Sadly, v5.4 isn't quite as good at analyzing results as are current
versions, but please feel free to send me the output.

Does that help?

							Thanx, Paul



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux