Re: [PATCH 2/2] udf: Restore i_lenAlloc when inode expansion fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 18, 2022 at 10:57:48AM +0100, Jan Kara wrote:
> When we fail to expand inode from inline format to a normal format, we
> restore inode to contain the original inline formatting but we forgot to
> set i_lenAlloc back. The mismatch between i_lenAlloc and i_size was then
> causing further problems such as warnings and lost data down the line.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Btw, how did the reported even hit that failure in a way where the
file system continues working?  If we fail to write back data we'd
probably better stop modifying anything and bail out..



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux