Hello Zack, On 1/20/22 05:06, Zack Rusin wrote: [snip] >>> >>> Hmm, the patch looks good but it doesn't work. After boot: >>> /proc/iomem >>> 50000000-7fffffff : pcie@0x40000000 >>> 78000000-7fffffff : 0000:00:0f.0 >>> 78000000-782fffff : BOOTFB >>> >>> and vmwgfx fails on pci_request_regions: >>> >>> kernel: fb0: switching to vmwgfx from simple >>> kernel: Console: switching to colour dummy device 80x25 >>> kernel: vmwgfx 0000:00:0f.0: BAR 2: can't reserve [mem 0x78000000- >>> 0x7fffffff 64bit pref] >>> kernel: vmwgfx: probe of 0000:00:0f.0 failed with error -16 >>> >>> leaving the system without a fb driver. >> >> OK, I suspect that it would work if you use simpledrm instead of >> into the kernel binary. > > Yes, simpledrm works fine. BTW, is there any remaining work before > distros can enable it by default? > Alpine already did AFAIK, OpenSUSE and Fedora are doing it soon I don't know about the others distros but I guess they will follow. >> >> If that works, would you consider protecting pci_request_region() >> with >> #if not defined(CONFIG_FB_SIMPLE) >> #endif >> >> with a FIXME comment? > > Yes, I think that's a good compromise. I'll respin the patch with that. > Agreed. Thanks a lot for testing the other patches anyways. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat
