On Wed, Jan 12, 2022 at 10:47:29AM -0800, Tadeusz Struk wrote: > On 1/12/22 10:35, Jarkko Sakkinen wrote: > > These look good to me! Thank you. I'm in process of compiling a test > > kernel. > > Thanks Jarkko, > You can run the new test before and after applying the change and see > how it behaves. Also just noticed a mistake in the comment, sorry but > it was quite late when I sent it. > > + /* > + * If ret is > 0 then tpm_dev_transmit returned the size of the > + * response. If ret is < 0 then tpm_dev_transmit failed and > + * returned a return code. > + */ > > In the above could you please replace: > > s/returned a return code/returned an error code/ > > before applying the patch. I would appreciate that. Please send new versions, there's also this: def test_flush_invlid_context() I'd figure "invlid" should be "invalid" You can add, as these changes do not change the semantics of the patches: Tested-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx> It's always best if you author the final version, as then a clear reference on what was accepted exist at lore.kernel.org. BR, Jarkko
