On Thu, Jan 13, 2022 at 01:37:42PM +0000, Aditya Garg wrote:
> The following patch was proposed as a fix for 5.16 when it was in beta stage but still hasn't been applied to stable 5.16 yet. Thus I am sending it to queue up
>
> commit 9651cf2cb14726c785240e9dc01b274a68e9959e upstream
>
> From: Orlando Chamberlain <redecorating@xxxxxxxxxxxxxx>
>
> This device is found in the MacBookPro16,2, and as the MacBookPro16,1 is
> from the same generation of MacBooks and has a UART with bxt_uart_info,
> it was incorrectly assumed that the MacBookPro16,2's UART would have the
> same info.
>
> This led to the wrong clock speed being used, and the Bluetooth
> controller exposed by the UART receiving and sending random data, which
> was incorrectly assumed to be an issue with the Bluetooth stuff, not an
> error with the UART side of things.
>
> Changing the info to spt_uart_info changes the clock speed and makes it
> send and receive data correctly.
>
> Fixes: ddb1ada ("mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART")
> Signed-off-by: Orlando Chamberlain <redecorating@xxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20211124091846.11114-1-redecorating@xxxxxxxxxxxxxx
> ---
> drivers/mfd/intel-lpss-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 9700e5acd0cd2d..a59aa147959b3e 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -254,7 +254,7 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
> { PCI_VDEVICE(INTEL, 0x34eb), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x34fb), (kernel_ulong_t)&spt_info },
> /* ICL-N */
> - { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&bxt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x38a8), (kernel_ulong_t)&spt_uart_info },
> /* TGL-H */
> { PCI_VDEVICE(INTEL, 0x43a7), (kernel_ulong_t)&bxt_uart_info },
> { PCI_VDEVICE(INTEL, 0x43a8), (kernel_ulong_t)&bxt_uart_info },
Now queued up, thanks.
greg k-h
