Re: [PATCH] HID: Ignore battery for Elan touchscreen on HP Envy X360 15t-dr100

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/9/22 23:55, Greg KH wrote:
On Sun, Jan 09, 2022 at 08:49:35PM -0700, Karl Kurbjun wrote:
Battery status on Elan tablet driver is reported for the HP ENVY x360
15t-dr100. There is no separate battery for the Elan controller resulting
in a battery level report of 0% or 1% depending on whether a stylus has
interacted with the screen. These low battery level reports causes a
variety of bad behavior in desktop environments. This patch adds the
appropriate quirk to indicate that the batery status is unused for this
target.

Signed-off-by: Karl Kurbjun <kkurbjun@xxxxxxxxx>
---
  drivers/hid/hid-ids.h   | 1 +
  drivers/hid/hid-input.c | 2 ++
  2 files changed, 3 insertions(+)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Thanks Greg,

Sorry for the mix-up on my side. I read that page before I submitted the patch but I went back and reread it. I was trying to follow "option 1" but I am guessing what I messed up was the cc in the signed-off area rather than the cc through email?

I was looking for an example of that - I found these threads:
https://lore.kernel.org/lkml/20130618161238.626277186@xxxxxxxxxxxxxxxxxxx/
and this one was what I was originally modeling my submission off of:
https://lore.kernel.org/lkml/20210125183218.373193047@xxxxxxxxxxxxxxxxxxx/

Is there an example of how I should add the cc to the sign-off area. As I read those threads the stable list was added to the email cc? Should I resubmit it to the linux-input with the appropriate change or follow a different flow now that the first email went out?

If I were going to resubmit I think I would need to to like so:

...
> target.
>
Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Karl Kurbjun <kkurbjun@xxxxxxxxx>
> ---
>  drivers/hid/hid-ids.h   | 1 +
>  drivers/hid/hid-input.c | 2 ++
>  2 files changed, 3 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 19da07777d62..a5a5a64c7abc 100644
...

Is that correct?

Karl



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux