Re: [PATCH 1/1] Fix uninitialiazed variable bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 8, 2022 at 8:52 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sat, Jan 08, 2022 at 07:37:59PM +0300, Ercan Ersoy wrote:
> >
> > This bug is in mem_cgroup_resize_max function
> > in mm/memcontrol.c source file.
> >
> > Signed-off-by: Ercan Ersoy <ercanersoy@xxxxxxxxxxxxxx>
>
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.

Even more relevantly, I think the patch is bogus.

What broken tool claims that 'ret' is uninitialized?

That mem_cgroup_resize_max() uses an endless loop construct
(admittedly an odd one - "do while (true)" is not the usual "for (;;)"
syntax). And every single 'break' out of that loop sets the 'ret'
variable.

Whatever tool reported this is just broken, or I'm blind.

                    Linus



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux