glibc's dprintf implementation tries to determine the current file position by calling lseek(fd, 0, SEEK_CUR). Unfortunately it treats receiving EINVAL as an error. See https://sourceware.org/bugzilla/show_bug.cgi?id=17830 >From what I can tell prior to Kay Sievers printk record commit e11fea92e13fb91c50bacca799a6131c81929986, calling lseek(fd, 0, SEEK_CUR) with such a file descriptor would not return an error. Prior to Kay's change, Arnd Bergmann's commit 6038f373a3dc1f1c26496e60b6c40b164716f07e seemed to go to some lengths to preserve the successful return code rather than returning (the perhaps more logical) -ESPIPE. glibc is happy with either a successful return or -ESPIPE. It seems that the consensus is to return -ESPIPE in this situation. Alexander Sverdlin supplied this test case: --8<-- #define _GNU_SOURCE #include <stdio.h> #include <fcntl.h> int main(int argc, char **argv) { return dprintf(open("/dev/kmsg", O_WRONLY), "\n") < 0; } -->8-- A variant of this fix was originally proposed in 2015[1]. The problem was woken up again in 2019[2] and this fix was posted[3] shortly afterwards, but it did not land. This version has been rebased to fix trivial conflicts. [1] https://lkml.org/lkml/2015/1/15/575 [2] https://lkml.org/lkml/2019/3/21/172 [3] https://lkml.org/lkml/2019/3/24/279 Signed-off-by: Mike Crowe <mac@xxxxxxxxxx> Cc: Arnd Bergmann <arnd@xxxxxxxx> Tested-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> Cc: stable@xxxxxxxxxxxxxxx Fixes: e11fea92e1 ("kmsg: export printk records to the /dev/kmsg interface") --- kernel/printk/printk.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 57b132b658e1..6013ea991378 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -803,6 +803,11 @@ static loff_t devkmsg_llseek(struct file *file, loff_t offset, int whence) /* after the last record */ atomic64_set(&user->seq, prb_next_seq(prb)); break; + case SEEK_CUR: + /* For compatibility with userspace expecting SEEK_CUR + * to not yield EINVAL. */ + ret = -ESPIPE; + break; default: ret = -EINVAL; } -- 2.30.2
