Hi, On 12/10/21 15:35, Mario Limonciello wrote: > This driver is intended to be used exclusively for suspend to idle > so callbacks to send OS_HINT during hibernate and S5 will set OS_HINT > at the wrong time leading to an undefined behavior. > > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans I will also add this to the fixes branch and include it in my next fixes pull-req for 5.17. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/amd-pmc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c > index 841c44cd64c2..230593ae5d6d 100644 > --- a/drivers/platform/x86/amd-pmc.c > +++ b/drivers/platform/x86/amd-pmc.c > @@ -508,7 +508,8 @@ static int __maybe_unused amd_pmc_resume(struct device *dev) > } > > static const struct dev_pm_ops amd_pmc_pm_ops = { > - SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(amd_pmc_suspend, amd_pmc_resume) > + .suspend_noirq = amd_pmc_suspend, > + .resume_noirq = amd_pmc_resume, > }; > > static const struct pci_device_id pmc_pci_ids[] = { >
