On Fri, Dec 17, 2021 at 09:42:21PM +0100, Johannes Berg wrote: > On Fri, 2021-12-17 at 20:35 +0000, Johannes Berg wrote: > > > > I'm not sure why you say it doesn't apply - it did for me? > > > > Oh, I'm an idiot, it doesn't *compile* afterwards since > IEEE80211_TXQ_STOP_NETIF_TX doesn't exist yet. > > Let's ignore this patch for now, but please take 2/2. > > I'll have to think if we even want to introduce this on the old kernels, > the bug that was reported required a firmware crash in the first place, > and it was reported on iwlwifi which doesn't even use TXQs on 4.19 yet. Yeah, I don't think it's needed, but as it was marked to go back really far, I wanted to give you the option to do so or not. Thanks for the 2/2 patch, I'll queue it up when I get a chance tomorrow. greg k-h