On Thu, Dec 16, 2021 at 09:07:13AM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > On Thu, Dec 16, 2021 at 08:00:30AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: > > Hi Greg, > > > > Incorrect 0644 in LTS for new selftest file, seen in 5.4.165 since > > "selftests: netfilter: add a vrf+conntrack testcase" was added to LTS. > > It's correct 755 in upstream, but somehow messed up in LTS :-( > > That is because quilt/git can not set modes of files. > > > linux-5.4.y > > =========== > > commit 8d3563ecbca3526fcc6639065c9fb11b2f234706 > > Author: Florian Westphal <fw@xxxxxxxxx> > > Date: Mon Oct 18 14:38:13 2021 +0200 > > > > selftests: netfilter: add a vrf+conntrack testcase > > > > commit 33b8aad21ac175eba9577a73eb62b0aa141c241c upstream. > > > > [...] > > diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh > > new file mode 100644 <---------------- > > > > > > linux-5.15.y > > ============ > > commit cffab968e94e513bdcef25e11402243ce2919803 > > [...] > > new file mode 100644 <---------------- > > > > > > upstream > > ======== > > $ git show 33b8aad21ac175eba9577a73eb62b0aa141c241c > > > > commit 33b8aad21ac175eba9577a73eb62b0aa141c241c > > Author: Florian Westphal <fw@xxxxxxxxx> > > Date: Mon Oct 18 14:38:13 2021 +0200 > > > > selftests: netfilter: add a vrf+conntrack testcase > > > > [...] > > diff --git a/tools/testing/selftests/netfilter/conntrack_vrf.sh b/tools/testing/selftests/netfilter/conntrack_vrf.sh > > new file mode 100755 <----------------------- > > > > > > -Tommi > > > > What about the 5.10.y tree? Does it need this change as well? To answer my own question, yes, it is an issue there too. I'll go do a release right now with the mode changed. thanks, greg k-h
