On Tue, Dec 14, 2021 at 10:00:47PM +0100, Armin Wolf wrote: > commit dbd3e6eaf3d813939b28e8a66e29d81cdc836445 upstream. > > The removal function is called regardless of whether > /proc/i8k was created successfully or not, the later > causing a WARN() on module removal. > Fix that by only calling the removal function > if /proc/i8k was created successfully. > > Since the original patch depends on the driver > registering a platform device, the backported patch > stores the return value of proc_create() and only > calls proc_remove_entry() on exit if proc_create() > was successful. > > Tested on a Inspiron 3505 for kernel 5.10. > > Cc: <stable@xxxxxxxxxxxxxxx> # 5.10.x > Signed-off-by: Armin Wolf <W_Armin@xxxxxx> > --- > drivers/hwmon/dell-smm-hwmon.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) All now queued up, thanks. greg k-h