Re: [PATCH] platform/x86: amd-pmc: only use callbacks for suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 10, 2021 at 9:06 PM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:
>
> This driver is intended to be used exclusively for suspend to idle
> so callbacks to send OS_HINT during hibernate and S5 will set OS_HINT
> at the wrong time leading to an undefined behavior.

...

>  static const struct dev_pm_ops amd_pmc_pm_ops = {
> -       SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(amd_pmc_suspend, amd_pmc_resume)
> +       .suspend_noirq = amd_pmc_suspend,
> +       .resume_noirq = amd_pmc_resume,

Can you simply switch to SET_NOIRQ_SYSTEM_SLEEP_PM_OPS()?

>  };


-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux