On Wed, 2021-12-08 at 13:57 +0100, Greg KH wrote:
> On Tue, Dec 07, 2021 at 06:23:49PM -0500, Lyude Paul wrote:
> > Huh, well this is strange. I'm assuming that you send these emails out as
> > part
> > of an automated script that tries applying patches and fails, but I think
> > something may have gone wrong here as I just tried cherry-picking
> > 04f0d6cc62cc1eaf9242c081520c024a17ba86a3 onto v5.15.6, and it applied
> > without
> > needing any manual conflict resolution. Any idea what might be going on?
>
> You mean 61e29a0956bd ("drm/i915: Add support for panels with VESA
> backlights with PWM enable/disable"), right?
>
> Anyway, yes, it fails to build:
>
> CC [M] drivers/gpu/drm/i915/display/intel_dp_aux_backlight.o
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c: In function
> ‘intel_dp_aux_vesa_enable_backlight’:
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:302:33: error:
> implicit declaration of function ‘intel_backlight_invert_pwm_level’; did you
> mean ‘intel_panel_invert_pwm_level’? [-Werror=implicit-function-declaration]
> 302 | u32 pwm_level =
> intel_backlight_invert_pwm_level(connector,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | intel_panel_invert_pwm_level
> cc1: all warnings being treated as errors
a-ha, totally forgot to build test it :P. Will fixup and send you a new
version in a bit, sorry for the noise!
>
> thanks,
>
> greg k-h
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
