Re: [PATCH v2 2/5] binder: use wake_up_pollfree()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 2/5] binder: use wake_up_pollfree()
From: Eric Biggers <ebiggers@xxxxxxxxxx>
Date: Tue, 7 Dec 2021 11:11:54 -0800
Cc: linux-aio@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Ramji Jiyani <ramjiyani@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Martijn Coenen <maco@xxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20211207095726.169766-3-ebiggers@kernel.org>

On Tue, Dec 07, 2021 at 01:57:23AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> wake_up_poll() uses nr_exclusive=1, so it's not guaranteed to wake up
> all non-exclusive waiters.  Yet, POLLFREE *must* wake up all waiters.

This is supposed to say "all exclusive waiters".  Same in patch 3.

- Eric

References:
- [PATCH v2 0/5] aio: fix use-after-free and missing wakeups
  - From: Eric Biggers
- [PATCH v2 2/5] binder: use wake_up_pollfree()
  - From: Eric Biggers

Prev by Date: Re: [PATCH v2 0/5] aio: fix use-after-free and missing wakeups
Next by Date: Re: [PATCH 5.10 000/125] 5.10.84-rc2 review
Previous by thread: [PATCH v2 2/5] binder: use wake_up_pollfree()
Next by thread: [PATCH v2 1/5] wait: add wake_up_pollfree()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]

Powered by Linux