On Fri, Dec 03, 2021 at 12:27:32PM -0500, James Zhu wrote: > From: Yifan Zhang <yifan1.zhang@xxxxxxx> > > commit afd18180c07026f94a80ff024acef5f4159084a4 upstream. > > When IOMMU disabled in sbios and kfd in iommuv2 path, iommuv2 > init will fail. But this failure should not block amdgpu driver init. > > Reported-by: youling <youling257@xxxxxxxxx> > Tested-by: youling <youling257@xxxxxxxxx> > Signed-off-by: Yifan Zhang <yifan1.zhang@xxxxxxx> > Reviewed-by: James Zhu <James.Zhu@xxxxxxx> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ---- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 3 +++ > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 488e574..f262c4e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -2255,10 +2255,6 @@ static int amdgpu_device_ip_init(struct amdgpu_device *adev) > amdgpu_xgmi_add_device(adev); > amdgpu_amdkfd_device_init(adev); > > - r = amdgpu_amdkfd_resume_iommu(adev); > - if (r) > - goto init_failed; > - > amdgpu_fru_get_product_info(adev); > > init_failed: > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > index 1204dae..b35f0af 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c > @@ -751,6 +751,9 @@ bool kgd2kfd_device_init(struct kfd_dev *kfd, > > kfd_cwsr_init(kfd); > > + if (kgd2kfd_resume_iommu(kfd)) > + goto device_iommu_error; No need to "fix up" the coding style here from the original, please always stick to what is upstream whenever possible :( thanks, greg k-h
