Re: [PATCH] ifcvf/vDPA: fix misuse virtio-net device config size for blk dev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 29, 2021 at 05:31:44PM +0800, Zhu Lingshan wrote:
This commit fixes a misuse of virtio-net device config size issue
for virtio-block devices.

A new member config_size in struct ifcvf_hw is introduced and would
be initialized through vdpa_dev_add() to record correct device
config size.

Signed-off-by: Zhu Lingshan <lingshan.zhu@xxxxxxxxx>
Reported-and-suggested-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>
Fixes: 6ad31d162a4e ("vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA")
Cc: <stable@xxxxxxxxxxxxxxx>
---
drivers/vdpa/ifcvf/ifcvf_base.c | 41 +++++++++++++++++++++++++--------
drivers/vdpa/ifcvf/ifcvf_base.h |  9 +++++---
drivers/vdpa/ifcvf/ifcvf_main.c | 24 ++++---------------
3 files changed, 41 insertions(+), 33 deletions(-)

The patch LGTM. Maybe we could add in the description that we rename some fields and functions in a more generic way.

In both cases:

Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>

Thanks,
Stefano




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux