On Mon, Nov 29, 2021 at 05:06:26AM -0800, Max Filippov wrote: > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > commit d67ed2510d28a1eb33171010d35cf52178cfcbdd upstream. > > CONFIG_OF can be set by a randconfig or by a user -- without setting the > early flattree option (OF_EARLY_FLATTREE). This causes build errors. > However, if randconfig or a user sets USE_OF in the Xtensa config, > the right kconfig symbols are set to fix the build. > > Fixes these build errors: > > ../arch/xtensa/kernel/setup.c:67:19: error: ‘__dtb_start’ undeclared here (not in a function); did you mean ‘dtb_start’? > 67 | void *dtb_start = __dtb_start; > | ^~~~~~~~~~~ > ../arch/xtensa/kernel/setup.c: In function 'xtensa_dt_io_area': > ../arch/xtensa/kernel/setup.c:201:14: error: implicit declaration of function 'of_flat_dt_is_compatible'; did you mean 'of_machine_is_compatible'? [-Werror=implicit-function-declaration] > 201 | if (!of_flat_dt_is_compatible(node, "simple-bus")) > ../arch/xtensa/kernel/setup.c:204:18: error: implicit declaration of function 'of_get_flat_dt_prop' [-Werror=implicit-function-declaration] > 204 | ranges = of_get_flat_dt_prop(node, "ranges", &len); > ../arch/xtensa/kernel/setup.c:204:16: error: assignment to 'const __be32 *' {aka 'const unsigned int *'} from 'int' makes pointer from integer without a cast [-Werror=int-conversion] > 204 | ranges = of_get_flat_dt_prop(node, "ranges", &len); > | ^ > ../arch/xtensa/kernel/setup.c: In function 'early_init_devtree': > ../arch/xtensa/kernel/setup.c:228:9: error: implicit declaration of function 'early_init_dt_scan'; did you mean 'early_init_devtree'? [-Werror=implicit-function-declaration] > 228 | early_init_dt_scan(params); > ../arch/xtensa/kernel/setup.c:229:9: error: implicit declaration of function 'of_scan_flat_dt' [-Werror=implicit-function-declaration] > 229 | of_scan_flat_dt(xtensa_dt_io_area, NULL); > > xtensa-elf-ld: arch/xtensa/mm/mmu.o:(.text+0x0): undefined reference to `xtensa_kio_paddr' > > Fixes: da844a81779e ("xtensa: add device trees support") > Fixes: 6cb971114f63 ("xtensa: remap io area defined in device tree") > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Signed-off-by: Max Filippov <jcmvbkbc@xxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > arch/xtensa/include/asm/vectors.h | 2 +- > arch/xtensa/kernel/setup.c | 12 ++++++------ > arch/xtensa/mm/mmu.c | 2 +- > 3 files changed, 8 insertions(+), 8 deletions(-) Thanks, now updated. greg k-h