On Mon, Nov 22, 2021 at 12:04 AM Sasha Levin <sashal@xxxxxxxxxx> wrote: > > This is a note to let you know that I've just added the patch titled > > HID: playstation: require multicolor LED functionality > > to the 5.15-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > hid-playstation-require-multicolor-led-functionality.patch > and it can be found in the queue-5.15 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@xxxxxxxxxxxxxxx> know about it. I am deeply puzzled by this cherry-pick. The purpose of this patch was to fix fc97b4d6a1a6 ("HID: playstation: expose DualSense lightbar through a multi-color LED.") So unless this patch gets backported in stable (and this is *not* a request to do so), bringing in this patch in 5.15 is wrong. Cheers, Benjamin > > > > commit e3d2570f947ede21072fd5a08c0d4bc40b6688ea > Author: Jiri Kosina <jkosina@xxxxxxx> > Date: Mon Nov 1 15:12:02 2021 +0100 > > HID: playstation: require multicolor LED functionality > > [ Upstream commit d7f1f9fec09adc1d77092cb2db0e56e2a4efd262 ] > > The driver requires multicolor LED support; express that in Kconfig. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Signed-off-by: Jiri Kosina <jkosina@xxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 3c33bf572d6d3..d78b1c1fb97e9 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -868,6 +868,7 @@ config HID_PLANTRONICS > config HID_PLAYSTATION > tristate "PlayStation HID Driver" > depends on HID > + depends on LEDS_CLASS_MULTICOLOR > select CRC32 > select POWER_SUPPLY > help >
