Hi, Sasha On Mon, Nov 22, 2021 at 1:25 AM Sasha Levin <sashal@xxxxxxxxxx> wrote: > > This is a note to let you know that I've just added the patch titled > > perf bench: Fix two memory leaks detected with ASan > > to the 4.9-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > perf-bench-fix-two-memory-leaks-detected-with-asan.patch > and it can be found in the queue-4.9 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@xxxxxxxxxxxxxxx> know about it. > > I think this patch should not be added to the stable tree. I think this patch should be reverted soon. Thanks, - Sohaib > > commit b1c29e2248629770cee7ac88cb9dfea91e07146b > Author: Sohaib Mohamed <sohaib.amhmd@xxxxxxxxx> > Date: Wed Nov 10 04:20:11 2021 +0200 > > perf bench: Fix two memory leaks detected with ASan > > [ Upstream commit 92723ea0f11d92496687db8c9725248e9d1e5e1d ] > > ASan reports memory leaks while running: > > $ perf bench sched all > > Fixes: e27454cc6352c422 ("perf bench: Add sched-messaging.c: Benchmark for scheduler and IPC mechanisms based on hackbench") > Signed-off-by: Sohaib Mohamed <sohaib.amhmd@xxxxxxxxx> > Acked-by: Ian Rogers <irogers@xxxxxxxxxx> > Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> > Cc: Hitoshi Mitake <h.mitake@xxxxxxxxx> > Cc: Jiri Olsa <jolsa@xxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Namhyung Kim <namhyung@xxxxxxxxxx> > Cc: Paul Russel <rusty@xxxxxxxxxxxxxxx> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > Cc: Pierre Gondois <pierre.gondois@xxxxxxx> > Link: http://lore.kernel.org/lkml/20211110022012.16620-1-sohaib.amhmd@xxxxxxxxx > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> > > diff --git a/tools/perf/bench/sched-messaging.c b/tools/perf/bench/sched-messaging.c > index 6a111e775210f..9322fd166bdaf 100644 > --- a/tools/perf/bench/sched-messaging.c > +++ b/tools/perf/bench/sched-messaging.c > @@ -225,6 +225,8 @@ static unsigned int group(pthread_t *pth, > snd_ctx->out_fds[i] = fds[1]; > if (!thread_mode) > close(fds[0]); > + > + free(ctx); > } > > /* Now we have all the fds, fork the senders */ > @@ -241,6 +243,8 @@ static unsigned int group(pthread_t *pth, > for (i = 0; i < num_fds; i++) > close(snd_ctx->out_fds[i]); > > + free(snd_ctx); > + > /* Return number of children to reap */ > return num_fds * 2; > }
